fix: handle 'latest' version string in plugin semver check#20714
Closed
AmanKRoy wants to merge 1 commit into
Closed
fix: handle 'latest' version string in plugin semver check#20714AmanKRoy wants to merge 1 commit into
AmanKRoy wants to merge 1 commit into
Conversation
When a plugin is installed without specifying a version, the cached version is 'latest'. semver.lt() throws 'Invalid Version: latest' when comparing it. Return false immediately since 'latest' always resolves to the latest version and is never outdated.
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate PR found:
Why it's related: This PR addresses the same issue of handling non-SemVer version strings (like 'latest') in the plugin installer's version checking logic. Both PRs appear to fix the same root cause - preventing crashes when plugin versions don't conform to valid SemVer format. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a plugin is specified without a version (e.g.,
my-plugininstead ofmy-plugin@1.0.0), opencode defaults the version to the string"latest". TheNpm.outdated()function then callssemver.lt("latest", ...), which throws because"latest"is not a valid SemVer string.This matches issue #12143.
Fix
Added an early return in
Npm.outdated()that skips the version check whencachedVersion === "latest".Testing
Fixes #12143