convert list tool to Tool.defineEffect#21899
Merged
kitlangton merged 1 commit intodevfrom Apr 10, 2026
Merged
Conversation
Use Ripgrep.Service for file listing via Stream instead of async generator. Use assertExternalDirectoryEffect. Add Effect.orDie before runPromise. Note: ListTool is not registered in the tool registry — it's only used by the CLI renderer. No registry changes needed.
kitlangton
force-pushed
the
kit/tool-effect-ls
branch
from
448a2e8 to
1f624bd
Compare
luke-barge-cko
added a commit
to luke-barge-cko/opencode-cko
that referenced
this pull request
Apr 10, 2026
* refactor(tool): convert question tool internals to Effect (anomalyco#21808) * refactor(tool): convert lsp tool internals to Effect (anomalyco#21806) * chore: generate * refactor(tool): convert plan tool internals to Effect (anomalyco#21807) * refactor(tui): switch to global events and start passing workspace param (anomalyco#21719) * refactor(tool): convert webfetch tool internals to Effect (anomalyco#21809) * chore: generate * refactor(tool): convert websearch tool internals to Effect (anomalyco#21810) * chore: generate * refactor(tool): convert codesearch tool internals to Effect (anomalyco#21811) * rector(core,tui): handle workspace state in project context, add workspace status, improve ui (anomalyco#21896) * refactor(tool): convert bash to defineEffect with ChildProcessSpawner (anomalyco#21895) * chore: generate * convert glob tool to Tool.defineEffect (anomalyco#21897) * chore: generate * tweak: make it so disabling uv or ruff fmters disables both (anomalyco#21921) * convert list tool to Tool.defineEffect (anomalyco#21899) * chore: generate * refactor(tool): convert write tool to Tool.defineEffect (anomalyco#21901) * zen: nemotron doc * chore: generate * refactor: convert edit tool to Tool.defineEffect (anomalyco#21904) * chore: generate --------- Co-authored-by: Kit Langton <kit.langton@gmail.com> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: James Long <longster@gmail.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: Frank <frank@anoma.ly>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListToolinsrc/tool/ls.tsfromTool.definetoTool.defineEffectfor consistency with other toolsRipgrep.files()async iterable andctx.ask/assertExternalDirectorycalls inEffect.promiseListToolin the tool registry (yield* ListTool+Tool.init+ builtin array)Test plan
bun run typecheckpasses (turbo ran all 13 packages successfully)