feat(keybinds): add cmd/command alias and macOS display support#23853
Open
jjangga0214 wants to merge 12 commits intoanomalyco:devfrom
Open
feat(keybinds): add cmd/command alias and macOS display support#23853jjangga0214 wants to merge 12 commits intoanomalyco:devfrom
jjangga0214 wants to merge 12 commits intoanomalyco:devfrom
Conversation
github-actions
Bot
added
the
needs:compliance
jjangga0214
force-pushed
the
agent-cmd-keybinds-v2
branch
2 times, most recently
from
fe9d384 to
a0e48a5
Compare
- Add cmd/command as alias for super in keybind parse - Display super as cmd on macOS in toString - Add tests for cmd/command alias parsing in test/keybind.test.ts
jjangga0214
force-pushed
the
agent-cmd-keybinds-v2
branch
from
a0e48a5 to
e3e6a6c
Compare
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
Replace regex super/cmd check with explicit darwin vs non-darwin expects. Add JSDoc on toString; clarify keybinds macOS copy. Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #653
Type of change
What does this PR do?
Add
cmdandcommandas aliases forsupermodifier in keybind parsing, and displaysuperascmdon macOS in the toString output. This provides better UX for macOS users who are familiar with Cmd key notation.How did you verify your code works?
Added tests in
test/keybind.test.tsfor parsing cmd/command aliases and verified existing tests pass.Checklist