feat(keybinds): use cmd as default keybind on macOS#23854
Open
jjangga0214 wants to merge 10 commits intoanomalyco:devfrom
Open
feat(keybinds): use cmd as default keybind on macOS#23854jjangga0214 wants to merge 10 commits intoanomalyco:devfrom
jjangga0214 wants to merge 10 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
This PR is closely related to #23854 (your current PR) as it appears to be addressing keybinds macOS support. While #23853 seems focused on adding cmd/command alias and display support, #23854 is specifically about using cmd as the default keybind on macOS. These could be complementary changes or potentially overlapping work - you may want to verify they're coordinated. |
jjangga0214
force-pushed
the
agent-macos-keybind-swap
branch
from
1f0c9bf to
e2cf5ee
Compare
jjangga0214
force-pushed
the
agent-macos-keybind-swap
branch
4 times, most recently
from
e89a42e to
4fffc4b
Compare
- Refactor keybind() to swap ctrl<->super on macOS via inverseOnMacOs flag - Add docs note about macOS using cmd instead of ctrl
jjangga0214
force-pushed
the
agent-macos-keybind-swap
branch
from
4fffc4b to
f34b86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Ref: #653
Type of change
What does this PR do?
Refactor
keybind()to automatically swap ctrl ↔ super on macOS viainverseOnMacOsflag (default: true). All keybinds defined withctrlwill automatically usesuper(cmd) on macOS, providing more native feel for macOS users.How did you verify your code works?
Checklist