Use Bun.which to locate opencode command#2414
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted improvement to the
createOpencodeServerfunction by ensuring that theopencodeexecutable is located using Bun'swhichutility, rather than relying on the system path. This change increases reliability when spawning the server process.spawncall inserver.tsto useBun.which('opencode')for locating theopencodeexecutable, ensuring the correct binary is used.Reasoning
Currently i have never been able to successfully use createOpencodeServer without forking the file over and performing some modification. Bun.which should solve this by giving an absolute path to the opencode binary