fix(app): persist project edit metadata#24745
Open
kzekiue wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24744
Type of change
What does this PR do?
fixes an issue where project edits weren’t showing up in the sidebar for local and global projects.
the edit dialog was already saving local project metadata via globalSync.project.meta, but the sidebar was only pulling in metadata from the server. so for projects tied to the global project record, the locally saved changes (like name or icon) were basically ignored, and the old values kept showing even after saving.
this change makes sure childStore.projectMeta is merged into the displayed project when there’s no server metadata, or when the project is global.
also updates avatar to read src reactively instead of grabbing it once during render, so it can properly switch from fallback initials to an uploaded image.
How did you verify your code works?
Tested locally with:
bun run dev:webbefore and after the changebun run script/build.ts --single --skip-installAlso ran:
bun typecheckinpackages/appbun typecheckinpackages/uibun turbo typecheckScreenshots / recordings
Not included.
Checklist