refactor(cli): convert pr command to effectCmd#25465
Merged
kitlangton merged 2 commits intodevfrom May 2, 2026
Merged
Conversation
Drops Instance.provide + AppRuntime.runPromise(Git.Service.use(...)) ceremony in favor of an Effect-native handler. process.exit(1) now flows through fail() / FormatError. Worktree + project info come from InstanceRef instead of legacy Instance globals.
Use Effect.die(new Error(...)) for the "opencode exited with code N" case so the global FormatError sees a plain Error (not a CliError), matching the original throw — exit code 1 with the "Unexpected error" banner — instead of inheriting the subprocess's exit code.
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
May 2, 2026
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli/cmd/pr.tsfrom the legacy Promise-stylecmd()wrapper toeffectCmd.Instance.provide+AppRuntime.runPromise(Git.Service.use(...))ceremony with an Effect-native handler that yields services directly.InstanceRefinstead of legacyInstanceglobals.process.exit(1)paths flow throughfail()→ existingFormatErrorglobal handler.Net: -36 lines, same behavior.
Test plan
bun run typecheckbun run test test/cli/— 137 passbun run src/index.ts prshows correct yargs help / arg validation