refactor(cli): convert import command to effectCmd#25467
Merged
kitlangton merged 2 commits intodevfrom May 2, 2026
Merged
Conversation
Drop bootstrap()/Instance.provide ceremony in favor of effectCmd's auto- provided InstanceRef. ShareNext.Service is yielded directly instead of through AppRuntime.runPromise wrappers. Body extracted to runImport so the legacy bootstrap-finally disposal can be matched via Effect.ensuring without re-indenting the entire body. Behavior preserved: dispose still runs on success / typed failure / defect / interruption (Effect.ensuring is a strict superset of the old try/finally).
4 tasks
- Use Effect.tryPromise + CliError for fetch and response.json so network/parse failures surface as clean one-liners instead of FiberFailure stack traces. - Make the InstanceRef invariant explicit: Effect.die instead of a silent early return when (impossibly) absent. - Reword the legacy-bootstrap comment to describe Effect.ensuring's exit-path coverage directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Independent of #25465 (pr command conversion).