fix(session): await cleanupRevert() to prevent dupe msgs after undo#2572
Merged
Conversation
Collaborator
|
gracias |
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Rwanbt
pushed a commit
to Rwanbt/opencode
that referenced
this pull request
May 5, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a fix for a race condition that could duplicate the last message when a user quickly performs an undo followed by an immediate send. I didn't realize how frequently this was happening to me until I built some tooling to analyze the reasoning traces from gpt-oss-120b. Here's an example of two instances displayed in the TUI (also confirmed via packet capture):
It's fairly easy to repro manually, at least on my machine (M3 Max). I use
<leader>, then pressu+enterin quick succession and get a near 100% hit rate on the bug.I don't know how many folks would be impacted by this. But I do run into this issue frequently because I do a ton of best-of-N sampling, both programmatically and manually.