Skip to content

Start effect-style compaction tests#26712

Merged
kitlangton merged 1 commit into
devfrom
cleanup/effectify-compaction-create-tests
May 10, 2026
Merged

Start effect-style compaction tests#26712
kitlangton merged 1 commit into
devfrom
cleanup/effectify-compaction-create-tests

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Add SessionCompaction.use using the existing serviceUse(Service) pattern.
  • Migrate the first compaction process test to it.live + provideTmpdirInstance + yielded services.
  • Add Effect-style message fixture helpers for the next compaction test migrations.

Testing

  • bun test --timeout 5000 test/session/compaction.test.ts -t "throws when parent is not a user message"
  • bun typecheck from packages/opencode
  • bunx prettier --check packages/opencode/src/session/compaction.ts packages/opencode/test/session/compaction.test.ts
  • pre-push bun turbo typecheck

Stack

@kitlangton kitlangton force-pushed the cleanup/effectify-compaction-create-tests branch from 65bcc4d to bbb1c94 Compare May 10, 2026 15:17
@kitlangton kitlangton changed the title Drop compaction Zod wrapper Start effect-style compaction tests May 10, 2026
@kitlangton kitlangton force-pushed the cleanup/openapi-boolean-query-routes branch from 0c04e32 to c047be5 Compare May 10, 2026 15:44
@kitlangton kitlangton requested a review from adamdotdevin as a code owner May 10, 2026 15:44
@kitlangton kitlangton force-pushed the cleanup/effectify-compaction-create-tests branch from bbb1c94 to 96312f6 Compare May 10, 2026 15:45
@kitlangton kitlangton force-pushed the cleanup/openapi-boolean-query-routes branch from c047be5 to 62b7961 Compare May 10, 2026 15:55
@kitlangton kitlangton force-pushed the cleanup/effectify-compaction-create-tests branch from 96312f6 to b3640c3 Compare May 10, 2026 15:55
@kitlangton kitlangton mentioned this pull request May 10, 2026
3 tasks
Base automatically changed from cleanup/openapi-boolean-query-routes to dev May 10, 2026 15:57
@kitlangton kitlangton force-pushed the cleanup/effectify-compaction-create-tests branch from b3640c3 to 6b7ad89 Compare May 10, 2026 15:59
@kitlangton kitlangton force-pushed the cleanup/effectify-compaction-create-tests branch from 6b7ad89 to f233a21 Compare May 10, 2026 16:03
@kitlangton kitlangton enabled auto-merge (squash) May 10, 2026 16:09
@kitlangton kitlangton merged commit a4f3ced into dev May 10, 2026
10 checks passed
@kitlangton kitlangton deleted the cleanup/effectify-compaction-create-tests branch May 10, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant