Skip to content

Remove redundant ID Zod overrides#26633

Merged
kitlangton merged 1 commit into
devfrom
cleanup/openapi-id-zod-overrides
May 10, 2026
Merged

Remove redundant ID Zod overrides#26633
kitlangton merged 1 commit into
devfrom
cleanup/openapi-id-zod-overrides

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 10, 2026

Summary

  • Remove redundant ZodOverride annotations from prefixed ID schemas now that Effect schemas carry the same prefix checks.
  • Move the remaining ToolID / EventID prefix constraints to Effect schemas too.
  • Remove the now-unused Identifier.schema(...) helper and unused identifier prefix entries.
  • Keep ID constructors and .zod statics backed by Effect schema-derived Zod output.

Testing

  • bun test --timeout 5000 test/server/httpapi-query-schema-drift.test.ts test/cli/github-action.test.ts test/project/migrate-global.test.ts test/session/message-v2.test.ts
  • bun typecheck
  • bunx prettier --check packages/opencode/src/id/id.ts packages/opencode/src/tool/schema.ts packages/opencode/src/sync/schema.ts packages/opencode/src/control-plane/schema.ts packages/opencode/src/permission/schema.ts packages/opencode/src/pty/schema.ts packages/opencode/src/question/schema.ts packages/opencode/src/session/schema.ts
  • bunx oxlint packages/opencode/src/id/id.ts packages/opencode/src/tool/schema.ts packages/opencode/src/sync/schema.ts packages/opencode/src/control-plane/schema.ts packages/opencode/src/permission/schema.ts packages/opencode/src/pty/schema.ts packages/opencode/src/question/schema.ts packages/opencode/src/session/schema.ts
  • pre-push bun turbo typecheck

Stack

@kitlangton kitlangton force-pushed the cleanup/openapi-id-zod-overrides branch from fd27a37 to 7a8bfb1 Compare May 10, 2026 03:06
@kitlangton kitlangton force-pushed the cleanup/openapi-id-zod-overrides branch from 7a8bfb1 to d8a8652 Compare May 10, 2026 03:08
@kitlangton kitlangton merged commit fb4bab8 into dev May 10, 2026
11 checks passed
@kitlangton kitlangton deleted the cleanup/openapi-id-zod-overrides branch May 10, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant