Remove redundant ID Zod overrides#26633
Merged
Merged
Conversation
fd27a37 to
7a8bfb1
Compare
7a8bfb1 to
d8a8652
Compare
This was referenced May 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZodOverrideannotations from prefixed ID schemas now that Effect schemas carry the same prefix checks.ToolID/EventIDprefix constraints to Effect schemas too.Identifier.schema(...)helper and unused identifier prefix entries..zodstatics backed by Effect schema-derived Zod output.Testing
bun test --timeout 5000 test/server/httpapi-query-schema-drift.test.ts test/cli/github-action.test.ts test/project/migrate-global.test.ts test/session/message-v2.test.tsbun typecheckbunx prettier --check packages/opencode/src/id/id.ts packages/opencode/src/tool/schema.ts packages/opencode/src/sync/schema.ts packages/opencode/src/control-plane/schema.ts packages/opencode/src/permission/schema.ts packages/opencode/src/pty/schema.ts packages/opencode/src/question/schema.ts packages/opencode/src/session/schema.tsbunx oxlint packages/opencode/src/id/id.ts packages/opencode/src/tool/schema.ts packages/opencode/src/sync/schema.ts packages/opencode/src/control-plane/schema.ts packages/opencode/src/permission/schema.ts packages/opencode/src/pty/schema.ts packages/opencode/src/question/schema.ts packages/opencode/src/session/schema.tsbun turbo typecheckStack