Skip to content

Use SyncEvent service at event call sites#26782

Merged
kitlangton merged 1 commit into
devfrom
cleanup/effectful-sync-event-call-sites
May 11, 2026
Merged

Use SyncEvent service at event call sites#26782
kitlangton merged 1 commit into
devfrom
cleanup/effectful-sync-event-call-sites

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 11, 2026

Summary

  • Replace v2 event emissions in Effect services with yielded SyncEvent.Service.run calls.
  • Preserve the existing OPENCODE_EXPERIMENTAL_EVENT_SYSTEM guard for v2 dual-write events.
  • Keep current bypass behavior for agent/model switch events by running those sync events directly.

Testing

  • bun typecheck from packages/opencode
  • bun test --timeout 5000 test/session/compaction.test.ts -t "creates a compaction user message and part"
  • bun test --timeout 5000 test/session/processor-effect.test.ts -t "publish retry status updates|capture llm input cleanly"
  • bun test --timeout 5000 test/session/prompt.test.ts -t "switch|shell|prompt"
  • bunx prettier --check ... for changed files
  • bunx oxlint ... for changed files (existing warnings only, no errors)
  • pre-push bun turbo typecheck

Stack

  1. Use SyncEvent service at event call sites #26782 👈 current
  2. Drop EventV2 run facade #26783

@kitlangton kitlangton force-pushed the cleanup/effectful-sync-event-call-sites branch from 6a3a341 to 9a72c3d Compare May 11, 2026 01:11
@kitlangton kitlangton merged commit effd967 into dev May 11, 2026
12 checks passed
@kitlangton kitlangton deleted the cleanup/effectful-sync-event-call-sites branch May 11, 2026 01:20
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
martinffx pushed a commit to martinffx/opencode that referenced this pull request May 12, 2026
martinffx pushed a commit to martinffx/opencode that referenced this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant