Skip to content

Drop EventV2 run facade#26783

Merged
kitlangton merged 1 commit into
devfrom
cleanup/drop-eventv2-run-facade
May 11, 2026
Merged

Drop EventV2 run facade#26783
kitlangton merged 1 commit into
devfrom
cleanup/drop-eventv2-run-facade

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented May 11, 2026

Summary

  • Delete the synchronous EventV2.run facade after migrating call sites to SyncEvent.Service.run.
  • Keep EventV2.define as the v2 event schema and SyncEvent-definition builder.

Testing

  • bun typecheck from packages/opencode
  • bun test --timeout 5000 test/session/compaction.test.ts -t "creates a compaction user message and part"
  • bun test --timeout 5000 test/session/processor-effect.test.ts -t "publish retry status updates|capture llm input cleanly"
  • bun test --timeout 5000 test/session/prompt.test.ts -t "switch|shell|prompt"
  • bunx prettier --check ... for changed files
  • bunx oxlint ... for changed files (existing warnings only, no errors)
  • pre-push bun turbo typecheck

Stack

  1. Use SyncEvent service at event call sites #26782
  2. Drop EventV2 run facade #26783 👈 current

@kitlangton kitlangton force-pushed the cleanup/effectful-sync-event-call-sites branch from 6a3a341 to 9a72c3d Compare May 11, 2026 01:11
@kitlangton kitlangton force-pushed the cleanup/drop-eventv2-run-facade branch from af69cdf to 49f7a34 Compare May 11, 2026 01:11
@kitlangton kitlangton changed the base branch from cleanup/effectful-sync-event-call-sites to dev May 11, 2026 01:19
@kitlangton kitlangton force-pushed the cleanup/drop-eventv2-run-facade branch from 49f7a34 to 37864a0 Compare May 11, 2026 01:20
@kitlangton kitlangton merged commit 83cb0f6 into dev May 11, 2026
9 checks passed
@kitlangton kitlangton deleted the cleanup/drop-eventv2-run-facade branch May 11, 2026 01:26
joshue031 pushed a commit to joshue031/opencode that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant