fix(app): add open folder button to V2 desktop session header#29888
Open
ComradeSwarog wants to merge 2 commits into
Open
fix(app): add open folder button to V2 desktop session header#29888ComradeSwarog wants to merge 2 commits into
ComradeSwarog wants to merge 2 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
The task has been manually tested. Menu: 
Open File Explorer: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29875
Type of change
What does this PR do?
The session header in the V2 desktop layout (
SessionHeaderV2Actions) was missing the "Open folder in file system" button and dropdown. TheSessionHeaderV2Actionscomponent only rendered StatusPopoverV2 + Review toggle, while the legacy fallback had the full Open-in button.The fix extends
SessionHeaderV2ActionsStatewith open-folder related fields (project directory, current app, options, menu state, callbacks) and renders the "Open in..." button with app icon and chevron dropdown insideSessionHeaderV2Actionsusing existing V2 components (MenuV2,IconButtonV2,IconV2,AppIcon).Changes:
packages/app/src/components/session/session-header.tsx— added Open-in button to V2 headerpackages/ui/src/v2/components/icon.tsx— addedcopyicon for the "Copy path" menu itemHow did you verify your code works?
Verified by reviewing the diff for correctness: the new V2 branch mirrors the existing legacy fallback structure, reusing the same state (
selectApp,openDir,copyPath,canOpen, etc.) already proven in production since the legacy path uses them. All components used (MenuV2,IconButtonV2,IconV2,AppIcon) are existing V2 primitives already in use elsewhere in the codebase.Checklist