feat(tui): add permission_fullscreen_default option - #34211
Conversation
Adds a permission_fullscreen_default tui.json option that opens the permission prompt in fullscreen by default when the prompt is fullscreen-capable (props.fullscreen). Defaults to false, preserving current behavior. Re-implements the request in anomalyco#12334, which the stalebot auto-closed after 90 days with no maintainer action.
github-actions
Bot
added
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
+1, this would be a very useful feature! I currently have to press Ctrl+F manually for every code edit. Happy to help test this branch if that helps. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
2 participants
Issue for this PR
Closes #12334
Type of change
What does this PR do?
Adds a
permission_fullscreen_defaultoption totui.json. When it'strue, the permission prompt opens in the fullscreen view instead of collapsed, so you don't have to toggle fullscreen on every prompt. Defaults tofalse, so behaviour is unchanged unless you opt in.It's gated on
props.fullscreen, so it only affects prompts that already support the fullscreen toggle. I added the field to theInfoschema inconfig/index.tsx;resolve()already spreads...input, so it flows through to the resolved config and the generatedtui.jsonschema without extra wiring. The only behaviour change is the initial value ofstore.expandedinpermission.tsx.#12334 requested this and was closed by the stale bot with no implementation.
How did you verify your code works?
Built locally, set
permission_fullscreen_default: trueintui.json, and triggered an edit permission prompt — it opens fullscreen. Unset /falseopens collapsed as before. Also confirmed the generatedtui.jsonschema includes the new key.Screenshots / recordings
No visual change beyond the existing fullscreen permission view opening by default. Can add a recording if that's preferred.
Checklist