Skip to content

fix(core): skip fff in node runtime#34353

Merged
Hona merged 2 commits into
devfrom
fix-fff-fallback
Jun 30, 2026
Merged

fix(core): skip fff in node runtime#34353
Hona merged 2 commits into
devfrom
fix-fff-fallback

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Explicitly select the ripgrep-backed filesystem search layer when running under Node
  • Prevent desktop sidecar from attempting to initialize fff even if the #fff import condition or dummy availability path changes

Trace notes

  • Built packages/opencode Node server bundle and verified the desktop chunk resolves #fff to fff.node.ts
  • Built packages/desktop and headlessly launched the generated out/main/sidecar.js with a fake process.parentPort
  • Queried /find/file?query=EXPORT&dirs=false&directory=...; response included src/EXPORT.md

Testing

  • bun typecheck from packages/core
  • bun test test/filesystem/search.test.ts test/location-filesystem.test.ts from packages/core
  • bun run script/build-node.ts from packages/opencode
  • bun run build from packages/desktop
  • pre-push bun turbo typecheck

@Hona @opencode-agent
fix(core): fallback to ripgrep when fff fails
59808e5 
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
@Hona
Hona marked this pull request as ready for review June 28, 2026 23:48
Copilot AI review requested due to automatic review settings June 28, 2026 23:48
Copilot AI reviewed Jun 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot mentioned this pull request Jun 29, 2026
Open
𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 @opencode-agent
fix(core): skip fff in node runtime
8f419a2 
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
@opencode-agent opencode-agent Bot changed the title fix(core): fallback to ripgrep when fff fails fix(core): skip fff in node runtime Jun 29, 2026
@Hona
Hona merged commit 8f1e13f into dev Jun 30, 2026
10 checks passed
@Hona
Hona deleted the fix-fff-fallback branch June 30, 2026 02:38
@opencode-agent opencode-agent Bot mentioned this pull request Jun 30, 2026
Merged
zz99mz-212 pushed a commit to zz99mz-212/opencode-New-Horizons that referenced this pull request Jul 16, 2026
@opencode-agent @Hona 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴
fix(core): skip fff in node runtime (anomalyco#34353)
d83b894 
Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Co-authored-by: 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 <little-frank@opencord.local>
avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 20, 2026
@opencode-agent @Hona 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴
fix(core): skip fff in node runtime (anomalyco#34353)
d1177eb 
Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Co-authored-by: 𝓛𝓲𝓽𝓽𝓵𝓮 𝓕𝓻𝓪𝓷𝓴 <little-frank@opencord.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hona