refactor(opencode): remove app service layer exports#34517
Merged
Conversation
This was referenced Jun 29, 2026
jlongster
force-pushed
the
remove-app-layers
branch
2 times, most recently
from
June 30, 2026 01:23
63f512a to
f944d0b
Compare
jlongster
force-pushed
the
remove-app-layers
branch
from
June 30, 2026 01:25
f944d0b to
41b6997
Compare
jlongster
force-pushed
the
remove-app-layers
branch
from
June 30, 2026 02:56
41b6997 to
cd3cf08
Compare
sharunkumar
added a commit
to sharunkumar/opencode
that referenced
this pull request
Jun 30, 2026
Resolve conflict in packages/opencode/src/command/index.ts. Upstream anomalyco#34517 ("remove app service layer exports") deleted the `Command.defaultLayer` export. The fork had modified that same block in d7bf75f ("don't block command list on MCP prompt loading") to add `Layer.provide(EventV2Bridge.defaultLayer)`, producing an edit/delete conflict on overlapping lines. Took upstream's resolution and dropped `defaultLayer`: - `Command.defaultLayer` is unused anywhere in the tree. - The fork's EventV2Bridge dependency is already wired through the `node` LayerNode (`deps: [..., EventV2Bridge.node]`), which is the actual runtime path. Non-blocking MCP prompt loading is preserved: base commands build synchronously and MCP prompts still fold in via `Effect.forkScoped` with a `command.changed` event. Typecheck passes.
zz99mz-212
pushed a commit
to zz99mz-212/opencode-New-Horizons
that referenced
this pull request
Jul 16, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Stack
Previous: #34516
Base: node-tests
Next: #34518