fix(tui): cleanup event listeners on component unmount to prevent MaxListenersExceededWarning#34616
Open
RuszLi wants to merge 2 commits into
Open
fix(tui): cleanup event listeners on component unmount to prevent MaxListenersExceededWarning#34616RuszLi wants to merge 2 commits into
RuszLi wants to merge 2 commits into
Conversation
…ListenersExceededWarning event.on() handlers in Session, App, and Prompt components were not being cleaned up via onCleanup(), causing listeners to accumulate each time the component remounted (e.g. switching sessions). After ~5 session switches the default Node.js maxListeners limit of 10 was exceeded, triggering MaxListenersExceededWarning. Fix: capture the unsubscribe function returned by event.on() and pass it to onCleanup() so listeners are removed when the component unmounts.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 similar comment
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #34617
Type of change
What does this PR do?
MaxListenersExceededWarning fires when 11+ event listeners accumulate on a single EventEmitter in the TUI. The stack trace shows it happens inside SolidJS reactive components during effect evaluation.
event.on() handlers in Session, App, and Prompt components were not cleaned up via onCleanup(). Each time a component remounts (e.g., switching sessions), a new listener is added without removing the old one. After ~5 session switches the default Node.js maxListeners: 10 limit is exceeded.
Fix: capture the unsubscribe function returned by event.on() and pass it to onCleanup().
How did you verify your code works?
Screenshots / recordings
N/A — internal code change, no UI impact.
Checklist