Skip to content

fix: Add parameter validation to all tools #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 3 commits into from
Oct 30, 2025
Merged

fix: Add parameter validation to all tools #3565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f5df56
fix: Add parameter validation to all tools
veracioux Oct 30, 2025
a546470
Merge remote-tracking branch 'upstream/dev' into fix/tool-execute-val…
veracioux Oct 30, 2025
d469eb8
Revert "fix: ensure tool inputs are zod validated"
veracioux Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/opencode/src/session/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ export namespace SessionPrompt {
args,
},
)
item.parameters.parse(args)
const result = await item.execute(args, {
sessionID: input.sessionID,
abort: options.abortSignal!,
Expand Down
9 changes: 7 additions & 2 deletions packages/opencode/src/tool/tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,13 @@ export namespace Tool {
return {
id,
init: async () => {
if (init instanceof Function) return init()
return init
const toolInfo = init instanceof Function ? await init() : init
const execute = toolInfo.execute
toolInfo.execute = (args, ctx) => {
toolInfo.parameters.parse(args)
return execute(args, ctx)
}
return toolInfo
},
}
}
Expand Down