feat: add pattern-based external file access permission#3592
Closed
Mishkun wants to merge 2 commits into
Closed
Conversation
- Add external_files permission to config schema (top-level and per-agent) - Update agent permission schema with external_files support - Implement permission checks in read, write, edit, and patch tools - Add pattern-based permission matching using Wildcard.all() - Default to 'ask' for security, support 'allow' and 'deny' - Add TUI display support for external_files permission prompts - Create comprehensive tests for all file tools - Maintain backward compatibility with bypassCwdCheck Closes anomalyco#3218
Contributor
Author
|
Oops, PR was meant to be a draft here. Need to check all of the functionality by hand |
Mishkun
marked this pull request as draft
October 30, 2025 22:01
…terns - Add expandPermissionPatterns utility to handle path expansion - Support tilde (~) expansion to home directory - Support relative paths (../, ./) resolved from Instance.directory - Preserve wildcards in patterns while expanding base paths - Update all file tools (read, write, edit, patch) to use path expansion - Add comprehensive tests for path expansion utility This fixes the issue where permission patterns like '~/projects/*' and '../docs/*' were not matching because they weren't expanded before wildcard comparison.
Contributor
Author
|
I'll provide new pr compatible with opentui migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've vibed a solution for my issue (#3218). I thought it might be cool to have a more granular control, so added bash-like complex permission for external files.
Claude overview:
external_filespermission with support forallow,ask, anddenymodes*/docs/*: "allow")askfor security while enabling flexible configuration for monorepo workflowsChanges
Tool Updates
Configuration Examples
Simple Permission
{ "permission": { "external_files": "ask" } }Pattern-Based (Monorepo)
{ "permission": { "external_files": { "*/docs/*": "allow", "*/packages/*/README.md": "allow", "*/node_modules/*": "deny", "*": "ask" } } }Per-Agent Configuration
{ "agent": { "build": { "permission": { "external_files": "allow" } } } }Closes #3218