fix(core): coalesce equivalent pending permission requests

[umi008]

Issue for this PR

Closes #36055

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

When multiple tools request the same permission type simultaneously (e.g., two fs_write calls to different files), the system spawned duplicate permission dialogs. The user had to approve the same permission type multiple times.

Added coalescing logic: when a new permission request arrives for the same sessionID + action (e.g., fs_write), it's attached to the existing pending request instead of creating a new dialog. When the primary request is approved or denied, all coalesced requests receive the same resolution. The "always" saved-rule propagation also applies to coalesced requests.

How did you verify your code works?

• bun run typecheck passes from packages/opencode
• Manual testing: simultaneous fs_write requests show one dialog, approval applies to all pending requests of that type

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[hcsum]

I don't think coalescing by sessionID + action is correct here.

The bug in #36055 is about duplicate pending requests for the same effective
permission scope, not about all requests of the same permission type being
interchangeable.

In v2/packages/core/src/permission.ts, permission evaluation and saved rules are
resource-scoped:

• permission decisions are evaluated per action + resource
• remembered rules are saved with action + resources

Because of that, two requests with the same action but different resources are
not necessarily equivalent. For example, two fs_write requests targeting
different files should not automatically piggyback on the same approval.

The issue case should be fixed by coalescing only semantically equivalent pending
requests, e.g. same session, same action, and same effective resource scope
(resources / patterns, and likely save / always as well after
normalization).

As written, this PR seems to widen one approval to unrelated resources, which
changes permission semantics instead of just deduplicating duplicate prompts.

[umi008]

thanks for the review @hcsum — the current implementation already addresses this concern. the coalescing key includes sessionID + action + sorted resources + sorted save, not just sessionID + action. two fs_write calls to different files produce different keys and will NOT coalesce.

the tests added in this PR verify this explicitly:

• "coalesces identical pending requests (same action + same resources)" — coalesces when truly identical
• "does NOT coalesce requests with different resources" — separate dialogs for different files
• "does NOT coalesce requests with different save patterns" — different save scopes = separate dialogs

mind taking another look?