fix(tui): publish session event when custom tool import fails#37185
Closed
mgajda wants to merge 4 commits into
Closed
fix(tui): publish session event when custom tool import fails#37185mgajda wants to merge 4 commits into
mgajda wants to merge 4 commits into
Conversation
When a custom tool file under .opencode/tool/ imports @opencode-ai/plugin but the package is not installed, the dynamic import() throws an unresolvable module error that crashes session startup with a raw stack trace. Instead, catch the import error, log a warning with the hinted message, and skip the tool. The tool loader continues with remaining tools.
…ct.catchAllCause Effect.catchAllCause does not exist in this version of Effect-TS. Use Effect.catchDefect to catch the synchronous ResolveMessage that Bun throws during dynamic import() of tool files with unresolvable imports. Also remove duplicate EventV2Bridge import that caused typecheck failure after rebase on dev.
- Wrap dynamic import() in Effect.promise + Effect.catchDefect so Bun's synchronous ResolveMessage is caught gracefully - Log a warning and skip the failing tool instead of crashing - Add test verifying broken import is skipped, valid tool loads - Add missing EventV2Bridge import - Typecheck: 30/30, Tests: 15/16 (1 pre-existing Zod test failure)
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom tool load errors are caught gracefully (warning logged, tool skipped) but nothing appears in the TUI. Publish a Session.Event.Error so the TUI can surface the failure, matching the pattern used by plugin load errors and skill load errors.
Fixes #37186