fix(session): resolve session overflow detection timing gaps#37194
Closed
johncoffee715 wants to merge 3 commits into
Closed
fix(session): resolve session overflow detection timing gaps#37194johncoffee715 wants to merge 3 commits into
johncoffee715 wants to merge 3 commits into
Conversation
…t models Remove COMPACTION_BUFFER (20K) constant and Math.min wrapper so usable() reserves the full maxOutputTokens instead of capping at 20K. Fixes: anomalyco#32656
…inue after compaction overflow Two fixes: 1. isOverflow() now accepts pendingTokens to estimate upcoming context 2. When compaction itself overflows, session returns 'continue' instead of 'stop' if auto-compaction is enabled, allowing the synthetic Continue... message to be created Fixes: anomalyco#17340, anomalyco#13946
…rflow on next step After completeToolCall(), estimate output tokens and check overflow before the next step begins. This catches large tool outputs that push context past the limit before step-finish. Fixes: anomalyco#10634
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
Author
|
caso queira encerrar eu deixei uma copia em meu repositoi, obrigado..! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Session overflow detection has several timing gaps:
Changes
Verification
Fixes #17340, Fixes #32656, Fixes #10634, Fixes #13946