fix: don't boot a full instance for session list#37477
Open
armancharan wants to merge 5 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
armancharan
commented
Jul 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
armancharan
commented
Jul 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37435
#37435
Type of change
What does this PR do?
session listwas loading a full instance just to query the db, which can take a long time. Skip that, resolve the project from cwd, and list by project id.How did you verify your code works?
bun test test/cli/session-list-bootstrap.test.ts test/server/session-list.test.tssession list does not run InstanceBootstrap plugins— plugins stay unloaded forsession list(still run foragent list)filters by projectID when projectID is provided— lists only this project's root sessions; excludes children and other projectsAcceptance
session listsession list does not run InstanceBootstrap pluginsprojectIDfilters by projectID when projectID is providedScreenshots / recordings
n/a
Checklist