fix(core): break skill import cycle#37479
Open
armancharan wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37424
#37424
Type of change
What does this PR do?
Importing
@opencode-ai/core/skillfirst crashed on a cycle through permission and session.SkillNotFoundErrorwas readingSkillV2.IDbefore that module finished loading.Use
Skill.IDfrom the schema package for the error and skill input type instead. Same ID schema, no init-order dependency.How did you verify your code works?
v2, then confirmed the import exits 0 after the changebun test test/public-import.test.tsbun run typecheckinpackages/coreScreenshots / recordings
n/a
Checklist