fix(session): encode persisted output formats#37541
Open
edwardgushchin wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26929
Type of change
What does this PR do?
Persisted V1 messages hydrate output formats as plain objects. The response encoder previously used
Schema.Class, which requires class instances and returned HTTP 400 when history contained either atextorjson_schemaformat.This changes those two wire schemas to
Schema.Struct, preserving the JSON shape while allowing persisted plain objects to encode. It also adds an endpoint regression test that saves both formats, reloads them through the database, and reads them throughGET /session/:id/message.This supersedes the encoding portion of #29632. Credit to @trevorWieland for the original diagnosis and fix.
How did you verify your code works?
bun test --timeout 60000 test/server/session-messages.test.tsinpackages/opencode— 6 passedbun typecheckinpackages/opencodebun typecheckinpackages/schemaThe repo-wide pre-push typecheck cannot complete in this Windows checkout because the existing
packages/enterprise/src/custom-elements.d.tssymlink is checked out as literal text; both changed packages typecheck successfully.Screenshots / recordings
Not applicable; this is an HTTP response-encoding fix with no UI changes.
Checklist