fix(core): detach disposed MCP registrations from root scope#37660
Merged
Conversation
github-actions Bot
pushed a commit
to ReStranger/opencode
that referenced
this pull request
Jul 19, 2026
* upstream/v2: mini: fix shell tool output display (anomalyco#37711) fix(core): detach disposed MCP registrations from root scope (anomalyco#37660) fix(core): preserve the first terminal failure (anomalyco#37705) fix(core): continue after malformed tool input (anomalyco#37701) fix(core): safely recover malformed tool input (anomalyco#37698) fix(simulation): render screenshot symbol glyphs (anomalyco#37691) fix(core): authorize relative external paths (anomalyco#37689) fix(tui): auto-approve permissions in auto mode feat(core): allow MCP Code Mode opt-out (anomalyco#37681) fix(codemode): stop leaking undefined into tool arguments (anomalyco#37652) fix(tui): style interrupted compaction neutrally (anomalyco#37655) fix(cli): harden managed service election (anomalyco#37645)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37308, addressing known trade-off #8 (no-op finalizers accumulate in the root scope).
register()previously pipedintegration.transform(...)withScope.provide(root), parking the transform's cleanup finalizer on the layer's root scope. Disposing a registration (onadd()replacement orremove()) made the transform inert but could not unregister that finalizer, so every replaced or removed remote OAuth server left one dead closure on the root scope until process exit — a slow, unbounded memory leak once add/remove become programmatically callable (HTTP endpoints, config reconciler).Fix: fork one child scope per registration and make
entry.registration.disposeclose that scope. Closing the child runs the transform's dispose finalizer (identical registry cleanup and reload behavior as before) and detaches the scope from root, so nothing accumulates. Closing an already-closed scope is a no-op, preserving dispose idempotency.No behavior change beyond the leak fix. Existing suite passes (18/18), typecheck clean.