fix(cli): package parcel watcher binding#37726
Open
loulanyue wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37686
Type of change
What does this PR do?
Ships the platform watcher.node beside each Bun executable and points compiled CLI runs at that sibling file unless an explicit path override is already set. This lets the existing watcher loader open the native addon from the real filesystem.
How did you verify your code works?
On macOS 26.4.1 arm64 with Bun 1.3.14, the compiled baseline logged watcher backend not supported. The rebuilt package logged watcher started with backend fs-events for the same isolated API reproduction and no path override.
Also passed packages/cli typecheck, compiled service lifecycle smoke test, Prettier, and oxlint with 0 errors. Oxlint retains one pre-existing CompileTarget assertion warning.
Screenshots / recordings
Not a UI change.
Checklist