Skip to content

fix(app): classify existing web profiles for layout transition#38117

Merged
Brendonovich merged 2 commits into
anomalyco:devfrom
dleopold:web-layout-toggle
Jul 24, 2026
Merged

fix(app): classify existing web profiles for layout transition#38117
Brendonovich merged 2 commits into
anomalyco:devfrom
dleopold:web-layout-toggle

Conversation

@dleopold

@dleopold dleopold commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Fixes #38124

Partially addresses #37546 by restoring the web layout escape hatch. Workspace support in the new layout remains outside this PR.

Related context: #37012 requests retaining the legacy layout permanently; this PR does not change the existing sunset policy.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Existing web profiles never receive layoutTransitionEligible because eligibility is currently initialized only by desktop onboarding. As a result, the existing layout transition control is hidden on web.

This change classifies previously unclassified web profiles once persisted settings and launch state are ready:

  • profiles with existing settings.v3 state or a recorded app version are eligible
  • blank web profiles are explicitly ineligible
  • the result is persisted in the existing settings field
  • desktop eligibility remains unchanged
  • the existing layout sunset remains unchanged

This keeps the original transition behavior: existing users get the temporary escape hatch, while blank profiles start on the new layout without the option to switch back.

How did you verify your code works?

  • bun test src/context/settings.test.ts — 12 passed, 0 failed
  • bun typecheck — passed
  • bun run build — passed
  • Manually tested the production preview:
    • blank web profile did not show the layout transition control
    • existing web state caused the control to appear
    • switching to the previous layout worked
    • the selected layout persisted after reload

Screenshots / recordings

The rendered control is unchanged; this PR only makes the existing control reachable for eligible web profiles.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@Brendonovich
Brendonovich enabled auto-merge (squash) July 24, 2026 08:15
@onelpawarai

onelpawarai commented Jul 24, 2026

Copy link
Copy Markdown

@Hona 🌟 Please contribute to my project and support me.
I would be truly grateful for your help and contributions. My goal is to make this project much bigger, more powerful, and more useful for everyone. Every idea, pull request, bug fix, feature, or suggestion makes a difference.
Let's build something amazing together. Thank you for your support! ❤️🚀

@Brendonovich
Brendonovich merged commit 57ddfeb into anomalyco:dev Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web: existing profiles are not eligible for the layout transition toggle

3 participants