fix(app): classify existing web profiles for layout transition#38117
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This was referenced Jul 21, 2026
Brendonovich
enabled auto-merge (squash)
July 24, 2026 08:15
|
@Hona 🌟 Please contribute to my project and support me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #38124
Partially addresses #37546 by restoring the web layout escape hatch. Workspace support in the new layout remains outside this PR.
Related context: #37012 requests retaining the legacy layout permanently; this PR does not change the existing sunset policy.
Type of change
What does this PR do?
Existing web profiles never receive
layoutTransitionEligiblebecause eligibility is currently initialized only by desktop onboarding. As a result, the existing layout transition control is hidden on web.This change classifies previously unclassified web profiles once persisted settings and launch state are ready:
settings.v3state or a recorded app version are eligibleThis keeps the original transition behavior: existing users get the temporary escape hatch, while blank profiles start on the new layout without the option to switch back.
How did you verify your code works?
bun test src/context/settings.test.ts— 12 passed, 0 failedbun typecheck— passedbun run build— passedScreenshots / recordings
The rendered control is unchanged; this PR only makes the existing control reachable for eligible web profiles.
Checklist