fix(core): authorize patch move destinations - #38133
Merged
Merged
Conversation
rekram1-node
force-pushed
the
patch-move-permission
branch
from
July 21, 2026 16:24
c5f6ca4 to
a8c8694
Compare
teknium1
added a commit
to NousResearch/hermes-agent
that referenced
this pull request
Jul 27, 2026
…zzy matching Port from anomalyco/opencode#38133/#38134 (patch Unicode matching corpus): extend UNICODE_MAP with the Zs space-separator family (en/em quad, en/em/ three-per-em/four-per-em/six-per-em/figure/punctuation/thin/hair spaces, narrow NBSP, medium mathematical space, CJK ideographic space) and the Unicode minus sign U+2212. Before: a file containing typographic spacing (French narrow NBSP, CJK ideographic spaces, math minus) never matched a model's ASCII old_string via the precise strategies — the edit only succeeded through the similarity-based context_aware fallback, which (a) can pick the wrong region (#54572 family) and (b) silently flattens the file's Unicode to ASCII on replacement. After: these match at unicode_normalized (strategy 7), whose _preserve_unicode_in_replacement keeps the file's typographic characters in unchanged spans. All additions are 1:1 mappings, so the existing position-mapping and preservation logic apply unchanged. Proven live before/after with a multi-line probe; 59 fuzzy-match + 188 file-tools/patch/skill-manager tests pass.
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…zzy matching Port from anomalyco/opencode#38133/NousResearch#38134 (patch Unicode matching corpus): extend UNICODE_MAP with the Zs space-separator family (en/em quad, en/em/ three-per-em/four-per-em/six-per-em/figure/punctuation/thin/hair spaces, narrow NBSP, medium mathematical space, CJK ideographic space) and the Unicode minus sign U+2212. Before: a file containing typographic spacing (French narrow NBSP, CJK ideographic spaces, math minus) never matched a model's ASCII old_string via the precise strategies — the edit only succeeded through the similarity-based context_aware fallback, which (a) can pick the wrong region (NousResearch#54572 family) and (b) silently flattens the file's Unicode to ASCII on replacement. After: these match at unicode_normalized (strategy 7), whose _preserve_unicode_in_replacement keeps the file's typographic characters in unchanged spans. All additions are 1:1 mappings, so the existing position-mapping and preservation logic apply unchanged. Proven live before/after with a multi-line probe; 59 fuzzy-match + 188 file-tools/patch/skill-manager tests pass.
jh1nresh
pushed a commit
to jh1nresh/hermes-agent
that referenced
this pull request
Aug 26, 2026
…zzy matching Port from anomalyco/opencode#38133/NousResearch#38134 (patch Unicode matching corpus): extend UNICODE_MAP with the Zs space-separator family (en/em quad, en/em/ three-per-em/four-per-em/six-per-em/figure/punctuation/thin/hair spaces, narrow NBSP, medium mathematical space, CJK ideographic space) and the Unicode minus sign U+2212. Before: a file containing typographic spacing (French narrow NBSP, CJK ideographic spaces, math minus) never matched a model's ASCII old_string via the precise strategies — the edit only succeeded through the similarity-based context_aware fallback, which (a) can pick the wrong region (NousResearch#54572 family) and (b) silently flattens the file's Unicode to ASCII on replacement. After: these match at unicode_normalized (strategy 7), whose _preserve_unicode_in_replacement keeps the file's typographic characters in unchanged spans. All additions are 1:1 mappings, so the existing position-mapping and preservation logic apply unchanged. Proven live before/after with a multi-line probe; 59 fuzzy-match + 188 file-tools/patch/skill-manager tests pass.
prmartinow
pushed a commit
to prmartinow/hermes-agent
that referenced
this pull request
Aug 26, 2026
…zzy matching Port from anomalyco/opencode#38133/NousResearch#38134 (patch Unicode matching corpus): extend UNICODE_MAP with the Zs space-separator family (en/em quad, en/em/ three-per-em/four-per-em/six-per-em/figure/punctuation/thin/hair spaces, narrow NBSP, medium mathematical space, CJK ideographic space) and the Unicode minus sign U+2212. Before: a file containing typographic spacing (French narrow NBSP, CJK ideographic spaces, math minus) never matched a model's ASCII old_string via the precise strategies — the edit only succeeded through the similarity-based context_aware fallback, which (a) can pick the wrong region (NousResearch#54572 family) and (b) silently flattens the file's Unicode to ASCII on replacement. After: these match at unicode_normalized (strategy 7), whose _preserve_unicode_in_replacement keeps the file's typographic characters in unchanged spans. All additions are 1:1 mappings, so the existing position-mapping and preservation logic apply unchanged. Proven live before/after with a multi-line probe; 59 fuzzy-match + 188 file-tools/patch/skill-manager tests pass.
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
…zzy matching Port from anomalyco/opencode#38133/NousResearch#38134 (patch Unicode matching corpus): extend UNICODE_MAP with the Zs space-separator family (en/em quad, en/em/ three-per-em/four-per-em/six-per-em/figure/punctuation/thin/hair spaces, narrow NBSP, medium mathematical space, CJK ideographic space) and the Unicode minus sign U+2212. Before: a file containing typographic spacing (French narrow NBSP, CJK ideographic spaces, math minus) never matched a model's ASCII old_string via the precise strategies — the edit only succeeded through the similarity-based context_aware fallback, which (a) can pick the wrong region (NousResearch#54572 family) and (b) silently flattens the file's Unicode to ASCII on replacement. After: these match at unicode_normalized (strategy 7), whose _preserve_unicode_in_replacement keeps the file's typographic characters in unchanged spans. All additions are 1:1 mappings, so the existing position-mapping and preservation logic apply unchanged. Proven live before/after with a multi-line probe; 59 fuzzy-match + 188 file-tools/patch/skill-manager tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test test/patch.test.ts test/tool-patch.test.ts(61 passed)bun typecheck