Skip to content

fix(tui): prevent duplicate message forks - #38240

Merged
rekram1-node merged 1 commit into
v2from
fork-once
Jul 22, 2026
Merged

fix(tui): prevent duplicate message forks#38240
rekram1-node merged 1 commit into
v2from
fork-once

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • initialize message-triggered forks as pending so their on-mount request does not change reactive dialog state and remount itself
  • keep the existing spinner fallback and interactive /fork picker unchanged

Root cause

The message action path starts the fork from DialogFork.onMount. It previously initialized pending to false, then immediately changed it to true; that reactive update remounted the stored dialog accessor, firing onMount and the non-idempotent fork request repeatedly.

Checks

  • bun typecheck (packages/tui)
  • bun test test/app-lifecycle.test.tsx --timeout 30000 (packages/tui)

Closes #38238

Requested by: @rekram1-node (Aiden Cline via Slack)

@opencode-agent
opencode-agent Bot requested a review from Hona July 22, 2026 03:49
@opencode-agent
opencode-agent Bot removed the request for review from Hona July 22, 2026 03:53
@opencode-agent
opencode-agent Bot force-pushed the fork-once branch 2 times, most recently from 9cc953e to 199ebbd Compare July 22, 2026 04:04
@rekram1-node
rekram1-node merged commit aea36d7 into v2 Jul 22, 2026
9 checks passed
@rekram1-node
rekram1-node deleted the fork-once branch July 22, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant