fix(session): apply compaction.reserved to models without limit.input#38843
Open
kagura-agent wants to merge 1 commit into
Open
fix(session): apply compaction.reserved to models without limit.input#38843kagura-agent wants to merge 1 commit into
kagura-agent wants to merge 1 commit into
Conversation
The usable() function in overflow.ts has two branches: one for models with limit.input and one without. The reserved token buffer was only subtracted in the limit.input branch, silently ignoring the user's compaction.reserved config for models that only declare context + output limits (which is common — most models.dev entries lack limit.input). Fixes anomalyco#38835
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #38835
Type of change
What does this PR do?
compaction.reservedis silently ignored for models withoutlimit.input. Theusable()function inoverflow.tscomputesreservedbut only subtracts it in thelimit.inputbranch — the fallback branch (used by most models.dev entries that only declarecontext+output) drops it entirely.The fix adds
- reservedto the fallback branch soreservedtakes effect consistently regardless of whetherlimit.inputis declared.How did you verify your code works?
Added
test/session/overflow.test.tswith 12 unit tests covering both branches ofusable()(with/withoutlimit.input), default vs explicitcompaction.reserved,outputTokenMaxoverride, andisOverflow()integration. All pass.Checklist