fix(native-llm): replace hardcoded provider gate with shared support set - #38925
Open
mgajda wants to merge 1 commit into
Open
fix(native-llm): replace hardcoded provider gate with shared support set#38925mgajda wants to merge 1 commit into
mgajda wants to merge 1 commit into
Conversation
Closes anomalyco#38893. The native LLM runtime's statusWithFetch() had a hardcoded allowlist of supported provider IDs and npm packages that excluded Google, Amazon Bedrock, Azure, and OpenRouter from the native path, even though native-request.ts had working adapters for them. Export SUPPORTED_NPM_PACKAGES from native-request.ts and use it in the gate so the two stay in sync by construction. Also fix API key propagation for providers with multiple env vars (GOOGLE_API_KEY, GOOGLE_GENERATIVE_AI_API_KEY, GEMINI_API_KEY) by removing the env.length === 1 guard — the found key is now always stored in provider.key.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #38893
Type of change
What does this PR do?
The native LLM runtime in
packages/opencode/src/session/llm/native-runtime.tshas a hardcoded provider allowlist instatusWithFetch()that blocks Google, Amazon Bedrock, Azure, and OpenRouter from the native LLM path, even thoughpackages/opencode/src/session/llm/native-request.tshas working adapters for them. These two lists are duplicated and drift apart when new providers are added.Changes:
SUPPORTED_NPM_PACKAGESset fromnative-request.ts(single source of truth)statusWithFetch()gate instead of hardcoded providerID/npm checksprovider.env.length === 1guard that discarded discovered keys for providers with multiple env varsHow did you verify your code works?
Checklist