fix(tui): hide background hint when all work is already backgrounded - #39242
Open
aakankshaduggal wants to merge 1 commit into
Open
fix(tui): hide background hint when all work is already backgrounded#39242aakankshaduggal wants to merge 1 commit into
aakankshaduggal wants to merge 1 commit into
Conversation
Check state.input.background in addition to state.metadata.background so the hint is suppressed immediately, before the async metadata update arrives. Fixes anomalyco#36940
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
This appears to be a related or potentially duplicate fix addressing the same background hint visibility issue in the TUI. You should review PR #37088 to determine if it already addresses the issue or if your PR #39242 provides an improved/alternative solution. |
Author
|
Note: PR #37088 addresses the same issue on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #36940
Type of change
What does this PR do?
The ctrl+b background hint checked
state.metadata.backgroundbut metadata is set asynchronously viactx.metadata(). There's a window where metadata is undefined even for tasks launched withbackground: true. This adds a check onstate.input.backgroundwhich is available immediately from the tool call parameters.Extracts
isForegroundRunningTaskto deduplicate the filter inforegroundTasksmemo and the inline<Show>condition.How did you verify your code works?
bun test --cwd packages/tui— 197 pass, 1 skip, 0 failbun run --cwd packages/tui typecheck— cleanbun turbo typecheck— 30/30 packages pass (ran via pre-push hook)Checklist