fix(tui): smooth new session tab handoff - #39745
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the visual jitter when a temporary
New sessiontab becomes the created session tab.Before / After
Before
The Home route stopped exposing the temporary tab as soon as navigation changed to the new session. The persisted tab store only added the real session after its locked file write completed, producing an intermediate layout without the active tab. The real tab could then render as
Untitled sessionand run the generic title wipe, producing mixed title frames before the session title arrived.After
The temporary tab remains active until the persisted collection contains the created session. Its initial real-tab title stays
New session, and the one-time handoff renames directly instead of replaying the normal retitle wipe. Tab count, position, and widths remain stable throughout.How
New sessiontitle during that handoff.Scope
This only changes the temporary-to-real tab handoff introduced by #39735. Session creation, persistence, and normal tab title animation are unchanged.
Testing
bun run test test/context/session-tabs.test.tsx test/context/session-tabs-model.test.tsinpackages/tui: 26 passedbun typecheckinpackages/tuiNew sessionto created-session title change with stable widths and no intermediate tab stateDemo
new-session-handoff.mp4