fix(tui): default tabs to global scope - #39783
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Session tabs now use one global tab set by default. Users can still choose
current directoryin TUI settings when they want separate tab sets per working directory.Before / After
Before: With tabs enabled and no explicit scope, each working directory had an independent tab set, and the settings dialog identified
current directoryas the default.After: With no explicit scope, all working directories share the global tab set. An explicit
tabs.scope: "cwd"continues to select per-directory storage, and the settings dialog identifiesglobalas the default.How
packages/tui/src/context/session-tabs.tsxto select global storage unlesscwdis explicit.packages/tui/src/component/dialog-config.tsx.Scope
This PR changes only the tab-strip scope default. The session picker default will follow in a separate PR.
Testing
bun run test test/context/session-tabs.test.tsxbun typecheckfrompackages/tuibunx prettier --check src/context/session-tabs.tsx src/component/dialog-config.tsx test/context/session-tabs.test.tsx