refactor(session): centralize fallback title policy - #39890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Centralize session-title fallback policy in the browser-safe
@opencode-ai/utilpackage so App, ACP, Core, Enterprise, and TUI no longer maintain subtly different constructors and recognizers.This keeps four existing behaviors explicit and separate:
How
session-title-fallback.tswith focused tests covering root, child, empty, historical, generated, and exact-match cases.sessionTitlehelpers.flowchart LR S[Session info] --> P{Consumer policy} P -->|String required| T[withTimestampedFallback] P -->|Human label| D[displayLabel] P -->|Terminal or splash| H[isFallbackTitle] P -->|Core title retry| E[isExactRootFallback]Scope
Testing
packages/util:bun run test,bun typecheck,bun run buildpackages/app:bun typecheck, focusedsrc/utils/session.test.tspackages/cli:bun typecheckpackages/core:bun typecheck, focusedtest/session-title.test.tspackages/enterprise:bun typecheckpackages/tui:bun typecheck, focusedtest/util/session.test.ts184.14 msbefore,190.95 msafter, identical consumed output