fix(app): correct "sesssion" typo in LayoutRoute tag - #40423
Open
avneeshjadhav04 wants to merge 1 commit into
Open
fix(app): correct "sesssion" typo in LayoutRoute tag#40423avneeshjadhav04 wants to merge 1 commit into
avneeshjadhav04 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40421
Type of change
What does this PR do?
Fixes a misspelled
LayoutRoutediscriminated-union tag:dir-new-sesssion(triple "s") ->dir-new-session, inpackages/app/src/context/layout.tsxand its consumers.The tag represents navigating to
/<dir>/sessionwithout a session id (a new session about to be created in that directory). It is derived from the URL viacurrentRoute()on every render and is never persisted, so the rename is behavior-neutral — but any future consumer writingdir-new-sessionwould silently never match the misspelled tag.Changed 4 occurrences in 3 files:
packages/app/src/context/layout.tsx(type definition + constructor)packages/app/src/components/titlebar.tsxpackages/app/src/components/settings-v2/dialog-settings-v2.tsxHow did you verify your code works?
bun typecheckinpackages/apppassessesssionmatches in the repoScreenshots / recordings
Not applicable — internal identifier rename, no UI change.
Checklist