Skip to content

fix(app): keep home sessions without opened projects - #40567

Closed
zcxGGmu wants to merge 1 commit into
anomalyco:devfrom
zcxGGmu:home-session-list
Closed

fix(app): keep home sessions without opened projects#40567
zcxGGmu wants to merge 1 commit into
anomalyco:devfrom
zcxGGmu:home-session-list

Conversation

@zcxGGmu

@zcxGGmu zcxGGmu commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • Extract the home session record builder into a pure helper for regression coverage
  • Keep unfiltered home sessions when no projects have been opened locally, instead of dropping the entire list
  • Use the session directory as fallback project metadata when no local project record matches

Refs #27837

Test Plan

  • bun test --conditions=solid --preload ./happydom.ts ./src/pages/home/home-sessions-controller.test.ts --test-name-pattern "keeps sessions when no projects have been opened locally"
  • bun test --conditions=solid --preload ./happydom.ts ./src/pages/home/home-sessions-controller.test.ts
  • bun run lint packages/app/src/pages/home/home-session-records.ts packages/app/src/pages/home/home-sessions-controller.tsx packages/app/src/pages/home/home-sessions-controller.test.ts
  • git diff --check

Note: packages/app typecheck currently fails on the existing src/custom-elements.d.ts placeholder (../../ui/src/custom-elements.d.ts), with no diff to that file in this branch.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on the search results, I found two potentially related PRs:

  1. PR fix(app): resolve a session's project by directory, not by shared ID #39666: fix(app): resolve a session's project by directory, not by shared ID

    • Related because it addresses session-project resolution using directory fallback logic
  2. PR fix(app): adopt the server directory when no project is open #38992: fix(app): adopt the server directory when no project is open

    • Related because it handles project metadata fallback to directory when no local project record matches

These PRs deal with similar concerns about resolving sessions to projects when no local project records exist. However, they appear to be addressing different aspects of the same problem area. You may want to review these PRs to ensure there's no overlapping functionality or to verify if PR #40567 supersedes or complements them.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Aug 5, 2026
@github-actions github-actions Bot closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants