refactor(app): remove unused UI helpers - #40686
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove confirmed-unused private app helper and controller surface. This is a callerless cleanup with no reachable UI behavior change.
How
layout.review.closePathandlayout.review.togglePath, introduced with the session helper cleanup indce7eceb28; retain the actively usedreview.openPathandreview.setOpenAPIs.file.tree.toggle, introduced with the file tree ind9eed4c6ca; retain active explicittree.expandandtree.collapsebehavior.mobileSidebar.showfrom the controller introduced inb8872d9d20; retain activemobileSidebar.hideandmobileSidebar.togglebehavior.sanitizeProject, added during the global sync refactor in2c58dd6203; retainnormalizeProjectInfo, including current-project canonical worktree and VCS normalization.formatKeybindKeys, added with app UI improvements in1bcb9d7cb9; retain activeformatKeybindPartsformatting forKeybindV2consumers.getSessionKey, introduced indce7eceb28; retainSessionStateKey.from(scope, route)construction so session identities remain server-scoped.Scope
closePathmock inpackages/app/happydom.ts.Testing
bun typecheckfrompackages/app(pass)bun run buildfrompackages/app(pass; existing Vite chunk/dynamic-import warnings)bun run test:unitfrompackages/app(688 pass, 1 unrelated existing failure: Arabic i18n parity is missing five English keys)git diff --check(pass)