refactor(core): remove orphaned message projector paths - #40705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the test-only in-memory session message projector and event handlers that cannot run through the durable SQL projector.
How
SessionMessageUpdater.memoryand its two adapter-specific tests.SessionMessageUpdater.updatefrom all session events toSessionEvent.DurableEvent.Scope
This does not change ephemeral event publication or live consumers. It only removes their unreachable paths from the durable message projector.
Testing
bun typecheckfrompackages/corebun run test test/session-projector.test.ts test/session-runner.test.ts test/session-prompt.test.ts test/session-compaction.test.tsfrompackages/core(194 passed)git diff --check