refactor(core): remove legacy account runtime schemas - #41173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dead Core Account runtime schemas while preserving the legacy SQLite account tables and all existing data. Current V2 authentication uses the Credential and Integration modules; no runtime code consumes the old Account login, polling, organization, token, or error schemas.
Before / After
Before:
packages/core/src/account.tsexported 101 lines of unused runtime schemas. The legacy Drizzle table declarations depended on four branded types from that otherwise dead module.After: The unused runtime module is gone.
account,account_state, andcontrol_accountremain unchanged in the canonical schema and in existing databases; their declarations use ordinary SQLite string types instead of importing the deleted runtime namespace.How
packages/core/src/account.ts.packages/core/src/account/sql.tsas the legacy schema owner.$typeannotations that depended on the deleted Account namespace; these annotations do not alter SQLite schema generation.Scope
Testing
bun run migration --checkfrompackages/core: passed; no schema changes or migration generated.bun run test test/database-migration.test.ts test/credential.test.tsfrompackages/core: 9 passed, 0 failed.bun typecheckfrompackages/core: passed.bun turbo typecheck --concurrency=3: 33 tasks passed.