fix(merman): tighten flowchart spacing - #41191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tighten ordinary horizontal flowchart chains while hardening top-level subgraph placement found during a final layout review.
Before / After
Before: unlabeled
LR/RLedges reserved at least 10 cells between ranks, making simple pipelines feel unnecessarily loose. The recent sibling-subgraph pass also serialized parallel peers and could miss nested or cyclic cluster dependencies.After: ordinary horizontal ranks use a 7-cell minimum. Labeled edges still expand to fit their labels, compact mode remains at 4 cells, and vertical spacing remains unchanged. Parallel sibling clusters retain the same primary rank, move across the flow axis only when their frames would overlap, and cyclic dependencies are ranked as one component.
How
DEFAULT_MIN_RANK_GAPfrom 10 to 7.Scope
Sequence and state spacing are unchanged. Edge labels continue to override the minimum rank gap when they need more room.
Testing
bun run typecheckinpackages/mermanbun run testinpackages/merman(230 tests)Demo
The same flowchart and sequence diagrams are held for one second under
opencode,tokyonight,github,rosepine, andgruvbox.recording-e6884445-8908-479f-9d3d-1d5e4ced4bdb.mp4