fix(cli): honor shell argument in completion command - #41235
Open
Cyame wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41232
Type of change
What does this PR do?
opencode completion fishcurrently prints a bash or zsh script depending on$SHELL. yargs (pinned at 18.0.0) picks the completion template from the environment and ignores the positional argument, so sourcing the output in fish fails with "Unsupported use of '='" at the firstocprompt.An upstream yargs bump does not fix this: no released yargs has fish support yet, and the unreleased one still keys off
$SHELLonly. Details are in #41232.This replaces yargs'
.completion()with acompletion [shell]command that:$SHELLwhen the argument is omittedThe fish template is the one from yargs/yargs#2568 (MIT).
--get-yargs-completionsis yargs core and is not touched.How did you verify your code works?
SHELL=/bin/zsh,opencode completion fishprints a fish script. Before this change it printed a zsh script.completion bashandcompletion zshoutput is unchanged.completion tcshfalls back to bash like the old code did.opencode --get-yargs-completions cstill lists subcommands.test/cli/cmd/completion.test.ts: 8 passing.tsgo --noEmitpasses.Screenshots / recordings
No UI changes.
Checklist