fix(codegen): write prettier-stable generated manifests - #41343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Formats the `.httpapi-codegen.json` manifest through prettier (json parser, repo print width) at write time, instead of raw `JSON.stringify(..., null, 2)`.
Why
The last red job on v2 CI. The generate bot (running on v2 since #41207) executes `script/generate.ts`, which ends with a repo-wide prettier pass — collapsing the short manifest arrays to single-line before committing. `check:generated` in `packages/client` regenerates without that pass, producing multi-line manifests, and `git diff --exit-code` fails:
```
-["client-error.ts", "client.ts", "index.ts"]
+[
...
```
Generated `.ts` files were already prettier-formatted at write time; the manifest was the one artifact that wasn't. Making it prettier-stable at the source fixes the check regardless of whether the bot's format pass runs afterward.
Testing