Only send bash updates every 200ms#4201
Closed
shantur wants to merge 1 commit into
Closed
Conversation
Closed
github-actions
Bot
force-pushed
the
dev
branch
3 times, most recently
from
November 22, 2025 18:07
f1dc981 to
3e15a39
Compare
github-actions
Bot
force-pushed
the
dev
branch
3 times, most recently
from
November 27, 2025 01:29
f8ee907 to
6a9856d
Compare
shantur
force-pushed
the
batch-bash-updates
branch
from
December 2, 2025 22:57
ddd4b65 to
8eb678f
Compare
Contributor
Author
|
@rekram1-node : The build failure isn't due to my changes. |
Collaborator
|
@shantur in tui/context/sdk.tsx we have a flush/buffer implemtentation, maybe we can make it a util and then use it here too? Also can we make the buffer 100ms?, 200ms is definitely noticeable and i'd try to be a bit more conservative w/ delay |
Collaborator
|
also you can do ./script/format.ts to fix the action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now bash tool updates are sent to UI for every update on output stream.
Each update is a complete output till not ( not delta ) so for high volume output commands like adb logcat or dmesg, each update (new line / character ) leads to a 2MB of json for UI to parse.
With this change we buffer for 200ms before sending one big chunk for UI to process rather than lots of big chunks for each character / line update.