feat(client): support service version ranges - #42023
Merged
Merged
Conversation
mattrobrob
force-pushed
the
service-version-ranges
branch
2 times, most recently
from
August 12, 2026 13:22
b2ab031 to
4ec80c0
Compare
mattrobrob
force-pushed
the
service-version-ranges
branch
from
August 12, 2026 13:25
4ec80c0 to
4537896
Compare
Member
|
Tweaked this a bit to keep the client dependency-free: |
thdxr
approved these changes
Aug 12, 2026
thdxr
left a comment
Member
There was a problem hiding this comment.
Reviewed the service compatibility changes and follow-up updates. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42010
Type of change
What does this PR do?
Allows the existing
versionoption inService.discover()andService.ensure()to accept npm semver ranges as well as exact values.Valid semver expressions are matched as ranges, including prereleases. Non-semver values such as
localandtestkeep their existing exact-string behavior. Promise and Effect service clients use the same matcher.How did you verify your code works?
cd packages/client && bun test(57 passed)cd packages/client && bun run typecheckcd packages/client && bun run buildgit diff --checkRepository-wide lint still has one unrelated existing error in
packages/session-ui/src/v2/components/prompt-input/index.tsx:163; targeted lint for the changed client files has zero errors.Screenshots / recordings
Not a UI change.
Checklist