fix(app): prevent settings dialog handler from locking up on cleanup - #42037
Open
MaaBlock wants to merge 1 commit into
Open
fix(app): prevent settings dialog handler from locking up on cleanup#42037MaaBlock wants to merge 1 commit into
MaaBlock wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42042
Type of change
What does this PR do?
useSettingsDialog drops subsequent open attempts if the component unmounts or re-renders once, because onCleanup permanently sets dead = true.
This removes the dead check so settings.open works reliably after re-renders. The run !== current check is kept to prevent race conditions when dynamic imports resolve out of order.
How did you verify your code works?
Tested hitting Cmd+, and using the command palette in the desktop app after switching tabs/routes. All 722 unit tests in packages/app pass.
Added Playwright E2E verification test in packages/app/e2e/user-story/settings-dialog-opening.spec.ts that presses Control+, and asserts div.settings-v2-dialog mounts into the DOM.
Screenshots / recordings
Verified in Playwright headless Chromium (1 passed): the dialog-v2 container renders upon Control+, shortcut trigger.
Checklist