fix(tui): keep exact-fit tab titles stationary - #42073
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep exact-fit session tab titles stationary and free of overflow fades when hover reveals the close button.
Before / After
Before
A title that exactly filled its resting tab width became one or two cells too wide only because hover reserved space for
×. That activated the marquee and its leading-edge fade, producing a dark mass at the front of an otherwise stationary-looking title.After
Overflow is classified against the tab's resting title width. Exact-fit titles remain stationary and unfaded on hover; titles that already overflowed continue to marquee within the narrower hovered viewport.
How
packages/tui/src/util/marquee.ts.Testing
bun run test test/util/marquee.test.tsfrompackages/tuibun typecheckfrompackages/tuibun turbo typecheck --concurrency=3