feat(merman): support cherry-pick in GitGraph diagrams - #42241
Open
Robin1987China wants to merge 1 commit into
Open
feat(merman): support cherry-pick in GitGraph diagrams#42241Robin1987China wants to merge 1 commit into
Robin1987China wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A — feat PR (feature PRs skip issue requirement per contributing guidelines)
Type of change
What does this PR do?
Completes the GitGraph feature landed in #42179: the parser currently rejects
cherry-pickwith "Cherry-pick is not supported". This PR implements cherry-pick per Mermaid semantics:cherry-pick id: "c1"(optionaltag:override) appends a cherry-picked commit to the current branch, inheriting the source commit's message and tagscommitByIdrender map stays unambiguous) and render with a hollow◌glyph in a dedicatedcherrycell style, echoing Mermaid's dashed-circle representationHow did you verify your code works?
packages/merman/src/gitgraph/diagram.test.ts: parse + inherited message/tags + tag override, missing-id and unknown-reference errors, hollow-glyph renderingbun test(packages/merman) — 327 passtsgo --noEmit(packages/merman) — cleanChecklist